Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_virtual_desktop_host_pool - support for public_network_access #25611

Merged
merged 4 commits into from
Apr 22, 2024
Merged

azurerm_virtual_desktop_host_pool - support for public_network_access #25611

merged 4 commits into from
Apr 22, 2024

Conversation

ASHR4
Copy link
Contributor

@ASHR4 ASHR4 commented Apr 14, 2024 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_virtual_desktop_host_pool - support for the public_network_access_enabled property

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #22429

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

stephybun
stephybun requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @ASHR4. Would you mind taking a look over the suggestion left-line. In addition could you also confirm that the default value returned by the API if the field isn't specified at all is indeed Enabled? Once that's done we can continue with the review.

internal/services/desktopvirtualization/virtual_desktop_host_pool_resource.go Outdated Show resolved Hide resolved
@ASHR4
Copy link
Contributor Author

ASHR4 commented Apr 20, 2024 •
edited
Loading

Thanks for this PR @ASHR4. Would you mind taking a look over the suggestion left-line. In addition could you also confirm that the default value returned by the API if the field isn't specified at all is indeed Enabled? Once that's done we can continue with the review.

Hi @stephybun, if the field is not supplied, it is indeed Enabled :)

@ASHR4
Copy link
Contributor Author

ASHR4 commented Apr 20, 2024

Updated acceptance tests

image

@ASHR4 ASHR4 requested a review from stephybun April 20, 2024 12:15
@ASHR4 ASHR4 changed the title azurerm_virtual_desktop_host_pool - support for public_network_access_enabled azurerm_virtual_desktop_host_pool - support for public_network_access Apr 20, 2024
stephybun
stephybun approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ASHR4 LGTM 🦀

@stephybun stephybun merged commit f8cb26b into hashicorp:main Apr 22, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.101.0 milestone Apr 22, 2024
@ASHR4 ASHR4 deleted the feature/public-access-hostpool branch April 22, 2024 06:45
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/virtual-desktops size/L
Projects
None yet
Milestone
v3.101.0
Development

Successfully merging this pull request may close these issues.

Support Host Pool properties.publicNetworkAccess
2 participants
@ASHR4 @stephybun